Skip to content
Snippets Groups Projects

#1073 Fix Reply Channel Valdiation

Merged Martin Vogel requested to merge bugfix/1073-invalid-reply-channel-validation into main
1 file
+ 5
5
Compare changes
  • Side-by-side
  • Inline
@@ -120,23 +120,23 @@ public class SubmissionReceiver {
private void validateMetadata(final Metadata metadata, final Submission submission, final AuthenticationTags authenticationTags) {
final ValidationResult validationResult = subscriber.validateMetadata(metadata, submission, authenticationTags);
evaluateValidationResult(submission, validationResult, "Metadata is invalid");
evaluateValidationResult(submission, validationResult);
}
private void validateAttachments(final List<AttachmentForValidation> attachmentForValidation, final Submission submission, final AuthenticationTags authenticationTags) {
final ValidationResult validationResult = subscriber.validateAttachments(attachmentForValidation, authenticationTags);
evaluateValidationResult(submission, validationResult, "Attachment validation failed");
evaluateValidationResult(submission, validationResult);
}
private void validateData(final Submission submission, final Metadata metadata, final byte[] decryptedData, final AuthenticationTags authenticationTags) {
final ValidationResult validationResult = subscriber.validateData(decryptedData, submission, metadata, authenticationTags);
evaluateValidationResult(submission, validationResult, "Data is invalid");
evaluateValidationResult(submission, validationResult);
}
private void evaluateValidationResult(final Submission submission, final ValidationResult validationResult, final String errorMessage) throws SubmissionRequestException {
private void evaluateValidationResult(final Submission submission, final ValidationResult validationResult) throws SubmissionRequestException {
if (validationResult.hasProblems()) {
rejectSubmissionWithProblem(submission, validationResult.getProblems().toArray(new Problem[0]));
throw new SubmissionRequestException(validationResult.hasError() ? validationResult.getError().getMessage() : errorMessage);
throw new SubmissionRequestException(validationResult.getProblems().stream().map(Problem::getDetail).collect(Collectors.joining()));
} else if (validationResult.hasError()) {
LOGGER.error(validationResult.getError().getMessage(), validationResult.getError());
throw new SubmissionRequestException(validationResult.getError().getMessage(), validationResult.getError());
Loading