refactor: cleanup tests (planning#667)

tools/src/test/java/dev/fitko/fitconnect/tools/KeyStoreReaderTest.java

@@ -29,12 +29,11 @@ class KeyStoreReaderTest {
     void loadKeyStore(@TempDir final Path tempDir) throws IOException, KeyStoreException {
 
         // Given
-        var path = "/badssl.com-client.p12";
-        byte[] bytes = getClass().getResourceAsStream(path).readAllBytes();
-        var configPath = Files.write(Path.of(tempDir.toString(), "badssl.com-client.p12"), bytes);
+        final byte[] resourceAsBytes = getResourceAsBytes("/badssl.com-client.p12");
+        var storePath = Files.write(Path.of(tempDir.toString(), "badssl.com-client.p12"), resourceAsBytes);
 
         // When
-        final KeyStore keyStore = uut.loadKeyStore(configPath.toString(), "badssl.com");
+        final KeyStore keyStore = uut.loadKeyStore(storePath.toString(), "badssl.com");
 
         // Then
         assertNotNull(keyStore);
@@ -45,12 +44,11 @@ class KeyStoreReaderTest {
     void loadKeyStoreWithWrongPassword(@TempDir final Path tempDir) throws IOException {
 
         // Given
-        var path = "/badssl.com-client.p12";
-        byte[] bytes = getClass().getResourceAsStream(path).readAllBytes();
-        var configPath = Files.write(Path.of(tempDir.toString(), "badssl.com-client.p12"), bytes);
+        final byte[] resourceAsBytes = getResourceAsBytes("/badssl.com-client.p12");
+        var storePath = Files.write(Path.of(tempDir.toString(), "badssl.com-client.p12"), resourceAsBytes);
 
         // When
-        var exception = assertThrows(FitConnectCertificateException.class, () -> uut.loadKeyStore(configPath.toString(), "wrongPass"));
+        var exception = assertThrows(FitConnectCertificateException.class, () -> uut.loadKeyStore(storePath.toString(), "wrongPass"));
 
         // Then
         assertThat(exception.getMessage(), containsString("keystore password was incorrect"));
@@ -65,4 +63,8 @@ class KeyStoreReaderTest {
         // Then
         assertThat(exception.getCause().getMessage(), containsString(Path.of("/wrong/path").toString()));
     }
+
+    private byte[] getResourceAsBytes(String name) throws IOException {
+        return getClass().getResourceAsStream(name).readAllBytes();
+    }
 }
\ No newline at end of file