update test, ditched obsolete functions with new versions

FitConnect/ClientFactory.cs

@@ -16,7 +16,7 @@ public static class ClientFactory {
 #endif
     }
 
-    [Obsolete]
+    [Obsolete($"Use {nameof(CreateSenderClient)} instead")]
     public static ISender GetSenderClient(FitConnectEnvironment environment, string clientId,
         string clientSecret, ILogger? logger = null) => CreateSenderClient(environment, clientId, clientSecret, logger);
 
@@ -40,7 +40,7 @@ public static class ClientFactory {
         }
     }
 
-    [Obsolete]
+    [Obsolete($"Use {nameof(CreateSubscriberClient)} instead")]
     public static ISubscriber GetSubscriberClient(FitConnectEnvironment environment, string clientId,
         string clientSecret, List<string> privateDecryptionKeys, string privateSigningKey,
         ILogger? logger = null) => CreateSubscriberClient(environment, clientId, clientSecret, privateDecryptionKeys,

Tests/BasicUnitTest/ChunkingTests.cs

@@ -8,7 +8,7 @@ using NUnit.Framework;
 namespace BasicUnitTest;
 
 public class ChunkingTests {
-    private string _originalFileSha;
+    private string? _originalFileSha;
 
     [SetUp]
     public void Setup() {

Tests/E2ETest/AutoRejectReplyChannel.cs

@@ -27,11 +27,11 @@ public class AutoRejectReplyChannel : EndToEndTestBase {
         Sender_GetEventLog_AfterAccepting();
         Sender_GetSubmissionState_AfterAccepting();
         Sender_GetStatus_AfterAccepting();
-        
+
         // Ignore - missing feature from other branch, reactivate after merge 717
         // SendingSubmissionWithReplyChannel_ToDestinationWithoutReplyChannel_ThrowsError()
     }
-    
+
     private void SendingSubmission() {
         var outgoing = SendableSubmission.Builder()
             .SetDestination(Settings.DestinationId)
@@ -155,11 +155,11 @@ public class AutoRejectReplyChannel : EndToEndTestBase {
         problems?.Where(p => p.Title == "Reply channel is not supported").Should()
             .NotBeNullOrEmpty();
     }
-    
+
     private void SendingSubmissionWithReplyChannel_ToDestinationWithoutReplyChannel_ThrowsError() {
         var container = Container.Create("NoReplyChannel");
         var settings = container.Resolve<IFitConnectSettings>();
-        var sender = ClientFactory.GetSenderClient(FitConnectEnvironment.Test,
+        var sender = ClientFactory.CreateSenderClient(FitConnectEnvironment.Test,
             settings.SenderClientId, settings.SenderClientSecret);
         var outgoing = SendableSubmission.Builder()
             .SetDestination(settings.DestinationId)
@@ -176,7 +176,7 @@ public class AutoRejectReplyChannel : EndToEndTestBase {
         sender.GetStatusForSubmissionAsync(sent).Result.SubmissionState.Should()
             .Be(EventType.Submit);
 
-        var subscriber = ClientFactory.GetSubscriberClient(FitConnectEnvironment.Test,
+        var subscriber = ClientFactory.CreateSubscriberClient(FitConnectEnvironment.Test,
             settings.SubscriberClientId, settings.SubscriberClientSecret,
             settings.PrivateDecryptionKeys, settings.PrivateSigningKey);