From c75122ee6be74389f3efbc3d81c50d0edb26d2dd Mon Sep 17 00:00:00 2001
From: Martin Vogel <martin.vogel@sinc.de>
Date: Thu, 23 Jun 2022 11:49:16 +0200
Subject: [PATCH] #414 remove comment since the exception class names describe
what kind of unexpected behaviour they cover
---
.../api/domain/model/events/SecurityEventToken.java | 4 ----
.../fitconnect/api/domain/validation/ValidationResult.java | 6 +++---
.../fitconnect/api/exceptions/AuthenticationException.java | 3 ---
.../fitconnect/api/exceptions/DecryptionException.java | 3 ---
.../fitconnect/api/exceptions/EncryptionException.java | 3 ---
5 files changed, 3 insertions(+), 16 deletions(-)
delete mode 100644 api/src/main/java/de/fitko/fitconnect/api/domain/model/events/SecurityEventToken.java
diff --git a/api/src/main/java/de/fitko/fitconnect/api/domain/model/events/SecurityEventToken.java b/api/src/main/java/de/fitko/fitconnect/api/domain/model/events/SecurityEventToken.java
deleted file mode 100644
index 177de5151..000000000
--- a/api/src/main/java/de/fitko/fitconnect/api/domain/model/events/SecurityEventToken.java
+++ /dev/null
@@ -1,4 +0,0 @@
-package de.fitko.fitconnect.api.domain.model.events;
-
-public class SecurityEventToken {
-}
diff --git a/api/src/main/java/de/fitko/fitconnect/api/domain/validation/ValidationResult.java b/api/src/main/java/de/fitko/fitconnect/api/domain/validation/ValidationResult.java
index c9f74030f..9c52d8614 100644
--- a/api/src/main/java/de/fitko/fitconnect/api/domain/validation/ValidationResult.java
+++ b/api/src/main/java/de/fitko/fitconnect/api/domain/validation/ValidationResult.java
@@ -1,7 +1,7 @@
package de.fitko.fitconnect.api.domain.validation;
/**
- * Wrapper for validations including errors that occurred
+ * Wrapper for validations including an exception
*/
public class ValidationResult {
@@ -12,7 +12,7 @@ public class ValidationResult {
this.isValid = isValid;
}
- private ValidationResult(final boolean isValid, Exception exception) {
+ private ValidationResult(final boolean isValid, final Exception exception) {
this.isValid = isValid;
this.error = exception;
}
@@ -21,7 +21,7 @@ public class ValidationResult {
return new ValidationResult(true);
}
- public static ValidationResult error(Exception exception) {
+ public static ValidationResult error(final Exception exception) {
return new ValidationResult(false, exception);
}
diff --git a/api/src/main/java/de/fitko/fitconnect/api/exceptions/AuthenticationException.java b/api/src/main/java/de/fitko/fitconnect/api/exceptions/AuthenticationException.java
index d81eb60d1..560737265 100644
--- a/api/src/main/java/de/fitko/fitconnect/api/exceptions/AuthenticationException.java
+++ b/api/src/main/java/de/fitko/fitconnect/api/exceptions/AuthenticationException.java
@@ -1,8 +1,5 @@
package de.fitko.fitconnect.api.exceptions;
-/**
- * An error that occurred during the OAuth authentication
- */
public class AuthenticationException extends RuntimeException {
public AuthenticationException(final String errorMessage, final Throwable error) {
diff --git a/api/src/main/java/de/fitko/fitconnect/api/exceptions/DecryptionException.java b/api/src/main/java/de/fitko/fitconnect/api/exceptions/DecryptionException.java
index dba418f8a..dcaadebe6 100644
--- a/api/src/main/java/de/fitko/fitconnect/api/exceptions/DecryptionException.java
+++ b/api/src/main/java/de/fitko/fitconnect/api/exceptions/DecryptionException.java
@@ -1,8 +1,5 @@
package de.fitko.fitconnect.api.exceptions;
-/**
- * An error that occurred decrypting data or attachments
- */
public class DecryptionException extends RuntimeException {
public DecryptionException(final String errorMessage) {
diff --git a/api/src/main/java/de/fitko/fitconnect/api/exceptions/EncryptionException.java b/api/src/main/java/de/fitko/fitconnect/api/exceptions/EncryptionException.java
index 985d10ecc..664a3ba0a 100644
--- a/api/src/main/java/de/fitko/fitconnect/api/exceptions/EncryptionException.java
+++ b/api/src/main/java/de/fitko/fitconnect/api/exceptions/EncryptionException.java
@@ -1,8 +1,5 @@
package de.fitko.fitconnect.api.exceptions;
-/**
- * An error that occurred whilst encrypting data or attachments
- */
public class EncryptionException extends RuntimeException {
public EncryptionException(final String errorMessage) {
--
GitLab