From 7604c26a4009716c82534c43d37986f44b1fe21d Mon Sep 17 00:00:00 2001 From: Martin Vogel <martin.vogel@sinc.de> Date: Wed, 8 May 2024 10:58:44 +0200 Subject: [PATCH] refactor: add problem to rejection (planning#1950)) --- .../integrationtests/SubscriberClientIT.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/integration-tests/src/test/java/dev/fitko/fitconnect/integrationtests/SubscriberClientIT.java b/integration-tests/src/test/java/dev/fitko/fitconnect/integrationtests/SubscriberClientIT.java index adb85f333..fb2b2dd84 100644 --- a/integration-tests/src/test/java/dev/fitko/fitconnect/integrationtests/SubscriberClientIT.java +++ b/integration-tests/src/test/java/dev/fitko/fitconnect/integrationtests/SubscriberClientIT.java @@ -7,6 +7,7 @@ import dev.fitko.fitconnect.api.domain.model.event.EventState; import dev.fitko.fitconnect.api.domain.model.event.Status; import dev.fitko.fitconnect.api.domain.model.event.problems.data.DataEncryptionIssue; import dev.fitko.fitconnect.api.domain.model.event.problems.data.IncorrectDataAuthenticationTag; +import dev.fitko.fitconnect.api.domain.model.event.problems.other.TechnicalError; import dev.fitko.fitconnect.api.domain.model.event.problems.submission.InvalidEventLog; import dev.fitko.fitconnect.api.domain.model.submission.ServiceType; import dev.fitko.fitconnect.api.domain.model.submission.SubmissionForPickup; @@ -370,7 +371,7 @@ public class SubscriberClientIT extends IntegrationTestBase { final UUID destinationId = UUID.fromString(System.getenv("TEST_DESTINATION_ID")); // ensure destination is empty - subscriberClient.getAvailableSubmissionsForDestination(destinationId).forEach(s -> subscriberClient.rejectSubmission(s, List.of())); + subscriberClient.getAvailableSubmissionsForDestination(destinationId).forEach(s -> subscriberClient.rejectSubmission(s, List.of(new TechnicalError()))); assertThat(subscriberClient.getAvailableSubmissionsForDestination(destinationId), hasSize(0)); final var submission = SendableSubmission.Builder() @@ -384,7 +385,7 @@ public class SubscriberClientIT extends IntegrationTestBase { senderClient.send(submission); // create some distance between submission dates Thread.sleep(1000); - } catch (InterruptedException e) { + } catch (final InterruptedException e) { throw new RuntimeException(e); } }); @@ -426,10 +427,10 @@ public class SubscriberClientIT extends IntegrationTestBase { IntStream.range(0, 10).mapToObj(i -> submission).forEach(senderClient::send); - ExecutorService es = Executors.newCachedThreadPool(); + final ExecutorService es = Executors.newCachedThreadPool(); final SubscriberClient subscriberClient = ClientFactory.createSubscriberClient(config); - for (SubmissionForPickup submissionForPickup : subscriberClient.getAvailableSubmissionsForDestination(submission.getDestinationId())) { + for (final SubmissionForPickup submissionForPickup : subscriberClient.getAvailableSubmissionsForDestination(submission.getDestinationId())) { es.execute(new SubscriberRunner(subscriberClient, submissionForPickup, "Thread-" + submissionForPickup.getSubmissionId())); } @@ -443,7 +444,7 @@ public class SubscriberClientIT extends IntegrationTestBase { private final SubmissionForPickup submissionForPickup; private final String threadName; - SubscriberRunner(SubscriberClient subscriberClient, SubmissionForPickup submissionForPickup, String threadName) { + SubscriberRunner(final SubscriberClient subscriberClient, final SubmissionForPickup submissionForPickup, final String threadName) { this.subscriberClient = subscriberClient; this.submissionForPickup = submissionForPickup; this.threadName = threadName; -- GitLab