From 3506833bfb3ac7e17612e2e727c7ab76ebb53c2a Mon Sep 17 00:00:00 2001
From: Klaus Fischer <klaus.fischer@eloware.com>
Date: Fri, 4 Nov 2022 15:13:19 +0100
Subject: [PATCH] WIP: Po review
---
E2ETest/RejectSubmissionTest.cs | 2 +-
FitConnect/Encryption/FitEncryption.cs | 6 +-----
FitConnect/Subscriber.cs | 3 +++
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/E2ETest/RejectSubmissionTest.cs b/E2ETest/RejectSubmissionTest.cs
index 393084aa..064aa666 100644
--- a/E2ETest/RejectSubmissionTest.cs
+++ b/E2ETest/RejectSubmissionTest.cs
@@ -72,7 +72,7 @@ public class RejectSubmissionTest : EndToEndTestBase {
public void Sender_GetSubmissionState_AfterRejecting() {
// Act
var status = Sender.GetStatusForSubmission(_caseId, Settings.DestinationId);
-
+
// Assert
status.Count.Should().BeGreaterThan(0);
status.ForEach(
diff --git a/FitConnect/Encryption/FitEncryption.cs b/FitConnect/Encryption/FitEncryption.cs
index 2e66b7de..f7df5174 100644
--- a/FitConnect/Encryption/FitEncryption.cs
+++ b/FitConnect/Encryption/FitEncryption.cs
@@ -146,11 +146,7 @@ public class FitEncryption {
var subject = "submission:" + submissionId;
_jwtHeader =
- new JwtHeader(new SigningCredentials(signingKey, "PS512")) {
- //{ "typ", "secevent+jwt" },
- // { "kid", signingKey.KeyId },
- // { "alg", "PS512" }
- };
+ new JwtHeader(new SigningCredentials(signingKey, "PS512"));
_jwtHeader["typ"] = "secevent+jwt";
diff --git a/FitConnect/Subscriber.cs b/FitConnect/Subscriber.cs
index 64128120..54955858 100644
--- a/FitConnect/Subscriber.cs
+++ b/FitConnect/Subscriber.cs
@@ -169,6 +169,9 @@ public class Subscriber : FitConnectClient,
}
+ /// <summary>
+ /// Accept or reject submission
+ /// </summary>
private void CompleteSubmission(Submission submission,
FinishSubmissionStatus status, Problems[]? problems = null) {
if (submission.Id == null || submission.CaseId == null ||
--
GitLab