Merged 0 Warning commit

IntegrationTests/Subscriber/SubscriberTestHappyPath.cs

@@ -16,18 +16,18 @@ public class SubscriberTestHappyPath : SubscriberTestBase {
     [Test]
     public void GetAvailableSubmissions_WithDestinationId_ShouldReturnSubmissionsForPickupDto() {
         // Act
-        var submissions = subscriber.GetAvailableSubmissions(desitnationId).ToList();
+        var submissions = Subscriber.GetAvailableSubmissions(DestinationId).ToList();
 
         // Assert
         submissions.Count().Should().BeGreaterThanOrEqualTo(2);
-        submissions.All(s => s.DestinationId == desitnationId).Should().BeTrue();
+        submissions.All(s => s.DestinationId == DestinationId).Should().BeTrue();
     }
 
     [Order(202)]
     [Test]
     public void GetAvailableSubmissions_WithOutDestinationId_ShouldReturnSubmissionsForPickupDto() {
         // Act
-        var submissions = subscriber.GetAvailableSubmissions().ToList();
+        var submissions = Subscriber.GetAvailableSubmissions().ToList();
 
         // Assert
         submissions.Count().Should().BeGreaterThan(0);
@@ -39,13 +39,13 @@ public class SubscriberTestHappyPath : SubscriberTestBase {
     public void GetAllSubmission_WithSubmissionId_ShouldReturnSubmissionsForPickupDto() {
         // Arrange
         var errorCounter = 0;
-        var submissions = subscriber.GetAvailableSubmissions().ToList();
+        var submissions = Subscriber.GetAvailableSubmissions().ToList();
         submissions.Count().Should().BeGreaterThan(0);
         var i = 0;
         foreach (var submissionId in submissions.Select(s => s.SubmissionId)) {
             // Act
             Console.WriteLine($"Getting submission {submissionId}");
-            var dto = subscriber.RequestSubmission(submissionId);
+            var dto = Subscriber.RequestSubmission(submissionId);
 
             // Assert
             errorCounter.Should().BeLessThan(submissions.Count());
@@ -62,9 +62,9 @@ public class SubscriberTestHappyPath : SubscriberTestBase {
     public void GetAttachment_WithSubmissionId_ShouldReturnSubmissionsForPickupDto(
         string submissionId) {
         // Act
-        var attachments = subscriber.RequestSubmission(submissionId).GetAttachments();
+        var attachments = Subscriber.RequestSubmission(submissionId).GetAttachments();
         foreach (var attachment in attachments) {
-            attachment.Content.Length.Should().BeGreaterThan(0);
+            attachment.Content!.Length.Should().BeGreaterThan(0);
             File.WriteAllBytes("attachments/test.pdf", attachment.Content);
         }
     }
@@ -72,11 +72,11 @@ public class SubscriberTestHappyPath : SubscriberTestBase {
     [Test]
     [Order(203)]
     public void GetStatus_ForAllPendingSubmissions() {
-        var submissions = subscriber.GetAvailableSubmissions().ToList();
+        var submissions = Subscriber.GetAvailableSubmissions().ToList();
         submissions.Count().Should().BeGreaterThan(0);
 
         foreach (var submission in submissions)
-            subscriber.GetStatusForSubmission(submission.CaseId).ForEach(s =>
+            Subscriber.GetStatusForSubmission(submission).ForEach(s =>
                 Logger.LogInformation("{SubmissionCaseId} - {ObjEventTime} - {ObjEventType}",
                     submission.CaseId, s.EventTime, s.EventType));
     }
@@ -86,7 +86,7 @@ public class SubscriberTestHappyPath : SubscriberTestBase {
     [Order(204)]
     public void GetAttachment_FromAllPendingSubmission_ShouldReturnAttachment() {
         // Arrange
-        var submissions = subscriber.GetAvailableSubmissions().ToList();
+        var submissions = Subscriber.GetAvailableSubmissions().ToList();
         submissions.Count().Should().BeGreaterThan(0);
 
         foreach (var submission in submissions) {
@@ -96,10 +96,10 @@ public class SubscriberTestHappyPath : SubscriberTestBase {
             if (!Directory.Exists($"./attachments/{submissionId}/"))
                 Directory.CreateDirectory($"./attachments/{submissionId}/");
 
-            subscriber.GetStatusForSubmission(submission.CaseId).ForEach(s =>
+            Subscriber.GetStatusForSubmission(submission).ForEach(s =>
                 Console.WriteLine($"{s.EventTime} - {s.EventType}"));
 
-            var subscriberWithSubmission = subscriber
+            var subscriberWithSubmission = Subscriber
                 .RequestSubmission(submissionId, true);
             var attachments = subscriberWithSubmission
                 .GetAttachments();
@@ -107,8 +107,8 @@ public class SubscriberTestHappyPath : SubscriberTestBase {
                 if ((attachment?.Content?.Length ?? 0) > 0)
                     File.WriteAllBytes(
                         Path.Combine($"./attachments/{submissionId}/",
-                            attachment.Filename),
-                        attachment.Content);
+                            attachment!.Filename!),
+                        attachment.Content!);
 
             Console.WriteLine($"Json Fachdaten: \r\n{subscriberWithSubmission.GetDataJson()}");
             Console.WriteLine($"Success {submissionId}");
@@ -123,14 +123,14 @@ public class SubscriberTestHappyPath : SubscriberTestBase {
     public void GetSingleSubmission_WithSubmissionId_ShouldReturnSubmissionsForPickupDto(
         string submissionId) {
         // Arrange
-        var submissions = subscriber.GetAvailableSubmissions().ToList();
+        var submissions = Subscriber.GetAvailableSubmissions().ToList();
         submissions.Count().Should().BeGreaterThan(0);
 
         Console.WriteLine($"Getting submission {submissionId}");
-        var dto = subscriber.RequestSubmission(submissionId);
+        var dto = Subscriber.RequestSubmission(submissionId);
 
         // Assert
-        dto.Submission.Id.Should().Be(submissionId);
+        dto.Submission!.Id.Should().Be(submissionId);
 
 
         Console.WriteLine(dto.Submission.Data);

MockContainer/MockContainer.cs

@@ -66,7 +66,7 @@ public static class Container {
 
         var credentials =
             JsonConvert.DeserializeObject<dynamic>(
-                File.ReadAllText("./encryptionKeys/credentials.json"));
+                File.ReadAllText("./encryptionKeys/credentials.json"))!;
 
         var senderClientId = (string)credentials.sender.clientId;
         var senderClientSecret = (string)credentials.sender.clientSecret;
@@ -113,8 +113,9 @@ public static class Container {
         submissionService.Setup(s =>
             s.ListSubmissions(It.IsAny<string>(), It.IsAny<int>(), It.IsAny<int>())).Returns(
             () =>
-                Task.Run(() => JsonConvert.DeserializeObject<SubmissionsForPickupDto>(
-                    @"{""offset"":0,""count"":3,""totalCount"":3,""submissions"":[{""destinationId"":""879ee109-a690-4db8-ab32-424284184d7d"",""submissionId"":""ce75a6b8-d72f-4b94-b09e-af6be35bc2ae""},{""destinationId"":""19c8489b-29b8-422f-b7db-919852cfb04b"",""submissionId"":""e364430f-5a3b-4284-ba9a-f2867ba421e6""},{""destinationId"":""80a0aac3-148d-42bb-9366-516ce6355348"",""submissionId"":""530ba588-2db9-4899-ab0d-0c0b57689271""}]}"))
+                JsonConvert.DeserializeObject<SubmissionsForPickupDto>(
+                    @"{""offset"":0,""count"":3,""totalCount"":3,""submissions"":[{""destinationId"":""879ee109-a690-4db8-ab32-424284184d7d"",""submissionId"":""ce75a6b8-d72f-4b94-b09e-af6be35bc2ae""},{""destinationId"":""19c8489b-29b8-422f-b7db-919852cfb04b"",""submissionId"":""e364430f-5a3b-4284-ba9a-f2867ba421e6""},{""destinationId"":""80a0aac3-148d-42bb-9366-516ce6355348"",""submissionId"":""530ba588-2db9-4899-ab0d-0c0b57689271""}]}")
+                !
         );
         submissionService.Setup(s => s.CreateSubmission(It.IsAny<CreateSubmissionDto>())).Returns(
             () => new SubmissionCreatedDto {
@@ -135,7 +136,7 @@ public static class Container {
                                 NullValueHandling = NullValueHandling.Ignore,
                                 Formatting = Formatting.Indented
                             })}");
-                    return Task.Run(() => new SubmissionReducedDto());
+                    return Task.Run(() => new SubmissionReducedDto())!;
                 });
 
         var data = new Data();